Commit 9f4db31e authored by Douglas Anderson's avatar Douglas Anderson Committed by Stephen Boyd

dt-bindings: clock: Fix YAML schemas for LPASS clocks on SC7180

The YAML schemas that landed forgot one clock: "bi_tcxo".  Presumably
the bindings were developed against the v4 version of the driver and
when the ".name" was removed in v5 of the driver things broke.

While touching this, add the needed includes in each example.  I
believe both examples are supposed to be independent of each other.

Let's fix the bindings.

Fixes: 381cc6f9 ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180")
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200731133006.1.Iee81b115f5be50d6d69500fe1bda11bba6e16143@changeidSigned-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 3386af51
...@@ -25,10 +25,12 @@ properties: ...@@ -25,10 +25,12 @@ properties:
clocks: clocks:
items: items:
- description: gcc_lpass_sway clock from GCC - description: gcc_lpass_sway clock from GCC
- description: Board XO source
clock-names: clock-names:
items: items:
- const: iface - const: iface
- const: bi_tcxo
power-domains: power-domains:
maxItems: 1 maxItems: 1
...@@ -77,24 +79,28 @@ additionalProperties: false ...@@ -77,24 +79,28 @@ additionalProperties: false
examples: examples:
- | - |
#include <dt-bindings/clock/qcom,rpmh.h>
#include <dt-bindings/clock/qcom,gcc-sc7180.h> #include <dt-bindings/clock/qcom,gcc-sc7180.h>
#include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h> #include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h>
clock-controller@63000000 { clock-controller@63000000 {
compatible = "qcom,sc7180-lpasshm"; compatible = "qcom,sc7180-lpasshm";
reg = <0x63000000 0x28>; reg = <0x63000000 0x28>;
clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>;
clock-names = "iface"; clock-names = "iface", "bi_tcxo";
#clock-cells = <1>; #clock-cells = <1>;
#power-domain-cells = <1>; #power-domain-cells = <1>;
}; };
- | - |
#include <dt-bindings/clock/qcom,rpmh.h>
#include <dt-bindings/clock/qcom,gcc-sc7180.h>
#include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h>
clock-controller@62d00000 { clock-controller@62d00000 {
compatible = "qcom,sc7180-lpasscorecc"; compatible = "qcom,sc7180-lpasscorecc";
reg = <0x62d00000 0x50000>, <0x62780000 0x30000>; reg = <0x62d00000 0x50000>, <0x62780000 0x30000>;
reg-names = "lpass_core_cc", "lpass_audio_cc"; reg-names = "lpass_core_cc", "lpass_audio_cc";
clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>;
clock-names = "iface"; clock-names = "iface", "bi_tcxo";
power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
#clock-cells = <1>; #clock-cells = <1>;
#power-domain-cells = <1>; #power-domain-cells = <1>;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment