Commit 9f848198 authored by Alex Elder's avatar Alex Elder Committed by Jakub Kicinski

net: ipa: reverse logic on escape buffer use

Starting with IPA v4.2 there is a GSI channel option to use an
"escape buffer" instead of prefetch buffers.  This should be used
for all channels *except* the AP command TX channel.  The logic
that implements this has it backwards; fix this bug.
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3567e233
...@@ -781,8 +781,10 @@ static void gsi_channel_program(struct gsi_channel *channel, bool doorbell) ...@@ -781,8 +781,10 @@ static void gsi_channel_program(struct gsi_channel *channel, bool doorbell)
if (gsi->version == IPA_VERSION_3_5_1 && doorbell) if (gsi->version == IPA_VERSION_3_5_1 && doorbell)
val |= USE_DB_ENG_FMASK; val |= USE_DB_ENG_FMASK;
/* Starting with IPA v4.0 the command channel uses the escape buffer */ /* v4.0 introduces an escape buffer for prefetch. We use it
if (gsi->version != IPA_VERSION_3_5_1 && channel->command) * on all but the AP command channel.
*/
if (gsi->version != IPA_VERSION_3_5_1 && !channel->command)
val |= USE_ESCAPE_BUF_ONLY_FMASK; val |= USE_ESCAPE_BUF_ONLY_FMASK;
iowrite32(val, gsi->virt + GSI_CH_C_QOS_OFFSET(channel_id)); iowrite32(val, gsi->virt + GSI_CH_C_QOS_OFFSET(channel_id));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment