Commit 9fb82f13 authored by Johan Hovold's avatar Johan Hovold Committed by Kleber Sacilotto de Souza

net: ethernet: stmmac: dwmac-sti: fix probe error path

BugLink: https://bugs.launchpad.net/bugs/1878232

commit 0a9e2271 upstream.

Make sure to disable clocks before returning on late probe errors.

Fixes: 8387ee21 ("stmmac: dwmac-sti: turn setup callback into a
probe function")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarIan May <ian.may@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent c0e0e9f9
......@@ -365,7 +365,16 @@ static int sti_dwmac_probe(struct platform_device *pdev)
if (ret)
return ret;
return stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
if (ret)
goto err_dwmac_exit;
return 0;
err_dwmac_exit:
sti_dwmac_exit(pdev, plat_dat->bsp_priv);
return ret;
}
static const struct sti_dwmac_of_data stih4xx_dwmac_data = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment