Commit a00da30c authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski

net: ethtool: fix __ethtool_dev_mm_supported() implementation

The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.

Link: https://lore.kernel.org/netdev/20230111161706.1465242-5-vladimir.oltean@nxp.com/
Fixes: 04692c90 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarFerenc Fejes <fejes@inf.elte.hu>
Link: https://lore.kernel.org/all/20230220122343.1156614-2-vladimir.oltean@nxp.com/Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7ec07774
......@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
if (ops && ops->get_mm)
ret = ops->get_mm(dev, &state);
return !!ret;
return !ret;
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment