Commit a05f8727 authored by Clément Léger's avatar Clément Léger Committed by Philipp Zabel

reset: core: add get_device()/put_device on rcdev

Since the rcdev structure is allocated by the reset controller drivers
themselves, they need to exists as long as there is a consumer. A call to
module_get() is already existing but that does not work when using
device-tree overlays. In order to guarantee that the underlying reset
controller device does not vanish while using it, add a get_device() call
when retrieving a reset control from a reset controller device and a
put_device() when releasing that control.
Signed-off-by: default avatarClément Léger <clement.leger@bootlin.com>
Signed-off-by: default avatarHerve Codina <herve.codina@bootlin.com>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarSteen Hegelund <Steen.Hegelund@microchip.com>
Acked-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240808154658.247873-8-herve.codina@bootlin.comSigned-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 0fa8ce76
...@@ -812,6 +812,7 @@ __reset_control_get_internal(struct reset_controller_dev *rcdev, ...@@ -812,6 +812,7 @@ __reset_control_get_internal(struct reset_controller_dev *rcdev,
kref_init(&rstc->refcnt); kref_init(&rstc->refcnt);
rstc->acquired = acquired; rstc->acquired = acquired;
rstc->shared = shared; rstc->shared = shared;
get_device(rcdev->dev);
return rstc; return rstc;
} }
...@@ -826,6 +827,7 @@ static void __reset_control_release(struct kref *kref) ...@@ -826,6 +827,7 @@ static void __reset_control_release(struct kref *kref)
module_put(rstc->rcdev->owner); module_put(rstc->rcdev->owner);
list_del(&rstc->list); list_del(&rstc->list);
put_device(rstc->rcdev->dev);
kfree(rstc); kfree(rstc);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment