Commit a12c3694 authored by Matt Fleming's avatar Matt Fleming Committed by Al Viro

microblaze: no need to reset handler if SA_ONESHOT

get_signal_to_deliver() already resets the signal handler if SA_ONESHOT is
set in ka->sa.sa_flags, there's no need to do it again in handle_signal().
 Furthermore, because we were modifying ka->sa.sa_handler (which is a copy
of sighand->action[]) instead of sighand->action[] the original code
actually had no effect on signal delivery.
Acked-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarMichal Simek <monstr@monstr.eu>
Signed-off-by: default avatarMatt Fleming <matt.fleming@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent de8f2ddd
...@@ -320,9 +320,6 @@ handle_signal(unsigned long sig, struct k_sigaction *ka, ...@@ -320,9 +320,6 @@ handle_signal(unsigned long sig, struct k_sigaction *ka,
else else
setup_rt_frame(sig, ka, NULL, oldset, regs); setup_rt_frame(sig, ka, NULL, oldset, regs);
if (ka->sa.sa_flags & SA_ONESHOT)
ka->sa.sa_handler = SIG_DFL;
if (!(ka->sa.sa_flags & SA_NODEFER)) { if (!(ka->sa.sa_flags & SA_NODEFER)) {
spin_lock_irq(&current->sighand->siglock); spin_lock_irq(&current->sighand->siglock);
sigorsets(&current->blocked, sigorsets(&current->blocked,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment