Commit a13c8f27 authored by Baoquan He's avatar Baoquan He Committed by Joerg Roedel

iommu/vt-d: Adjust the return value of the parse_ioapics_under_ir

Adjust the return value of parse_ioapics_under_ir as
negative value representing failure and "0" representing
succcess. Just make it consistent with other function
implementations, and we can judge if calling is successfull
by if (!parse_ioapics_under_ir()) style.
Signed-off-by: default avatarBaoquan He <bhe@redhat.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 344cb4e0
...@@ -690,7 +690,7 @@ static int __init intel_prepare_irq_remapping(void) ...@@ -690,7 +690,7 @@ static int __init intel_prepare_irq_remapping(void)
if (!dmar_ir_support()) if (!dmar_ir_support())
return -ENODEV; return -ENODEV;
if (parse_ioapics_under_ir() != 1) { if (!parse_ioapics_under_ir()) {
pr_info("Not enabling interrupt remapping\n"); pr_info("Not enabling interrupt remapping\n");
goto error; goto error;
} }
...@@ -943,7 +943,7 @@ static int __init parse_ioapics_under_ir(void) ...@@ -943,7 +943,7 @@ static int __init parse_ioapics_under_ir(void)
} }
if (!ir_supported) if (!ir_supported)
return 0; return -ENODEV;
for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) { for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) {
int ioapic_id = mpc_ioapic_id(ioapic_idx); int ioapic_id = mpc_ioapic_id(ioapic_idx);
...@@ -955,7 +955,7 @@ static int __init parse_ioapics_under_ir(void) ...@@ -955,7 +955,7 @@ static int __init parse_ioapics_under_ir(void)
} }
} }
return 1; return 0;
} }
static int __init ir_dev_scope_init(void) static int __init ir_dev_scope_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment