Commit a1459c1c authored by Mark Brown's avatar Mark Brown Committed by David S. Miller

net: phy: spi_ks8895: Don't leak references to SPI devices

The ks8895 driver is using spi_dev_get() apparently just to take a copy
of the SPI device used to instantiate it but never calls spi_dev_put()
to free it.  Since the device is guaranteed to exist between probe() and
remove() there should be no need for the driver to take an extra
reference to it so fix the leak by just using a straight assignment.
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 210990b0
...@@ -441,7 +441,7 @@ static int ks8995_probe(struct spi_device *spi) ...@@ -441,7 +441,7 @@ static int ks8995_probe(struct spi_device *spi)
return -ENOMEM; return -ENOMEM;
mutex_init(&ks->lock); mutex_init(&ks->lock);
ks->spi = spi_dev_get(spi); ks->spi = spi;
ks->chip = &ks8995_chip[variant]; ks->chip = &ks8995_chip[variant];
if (ks->spi->dev.of_node) { if (ks->spi->dev.of_node) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment