Commit a1d19bd4 authored by Frank Rowand's avatar Frank Rowand Committed by Rob Herring

of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove

A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
or an embedded errno.  overlay_notify() incorrectly reports an
error for NOTIFY_OK.

Reported-by: atull@kernel.org
Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 34ca5d76
...@@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs, ...@@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
ret = blocking_notifier_call_chain(&overlay_notify_chain, ret = blocking_notifier_call_chain(&overlay_notify_chain,
action, &nd); action, &nd);
if (ret == NOTIFY_STOP) if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
return 0; return 0;
if (ret) { if (ret) {
ret = notifier_to_errno(ret); ret = notifier_to_errno(ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment