Commit a21b7f0c authored by Navid Emamdoost's avatar Navid Emamdoost Committed by David S. Miller

net: qrtr: fix memort leak in qrtr_tun_write_iter

In qrtr_tun_write_iter the allocated kbuf should be release in case of
error or success return.

v2 Update: Thanks to David Miller for pointing out the release on success
path as well.
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 10cc514f
...@@ -84,11 +84,14 @@ static ssize_t qrtr_tun_write_iter(struct kiocb *iocb, struct iov_iter *from) ...@@ -84,11 +84,14 @@ static ssize_t qrtr_tun_write_iter(struct kiocb *iocb, struct iov_iter *from)
if (!kbuf) if (!kbuf)
return -ENOMEM; return -ENOMEM;
if (!copy_from_iter_full(kbuf, len, from)) if (!copy_from_iter_full(kbuf, len, from)) {
kfree(kbuf);
return -EFAULT; return -EFAULT;
}
ret = qrtr_endpoint_post(&tun->ep, kbuf, len); ret = qrtr_endpoint_post(&tun->ep, kbuf, len);
kfree(kbuf);
return ret < 0 ? ret : len; return ret < 0 ? ret : len;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment