Commit a4eb490a authored by Arvind Yadav's avatar Arvind Yadav Committed by Jiri Kosina

HID: intel-ish-hid: use put_device() instead of kfree()

Never directly free @dev after calling device_register(), even
if it returned an error. Always use put_device() to give up the
reference initialized.
Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 749ab300
...@@ -418,7 +418,7 @@ static struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev, ...@@ -418,7 +418,7 @@ static struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
list_del(&device->device_link); list_del(&device->device_link);
spin_unlock_irqrestore(&dev->device_list_lock, flags); spin_unlock_irqrestore(&dev->device_list_lock, flags);
dev_err(dev->devc, "Failed to register ISHTP client device\n"); dev_err(dev->devc, "Failed to register ISHTP client device\n");
kfree(device); put_device(&device->dev);
return NULL; return NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment