Commit a513ad2d authored by Dan Carpenter's avatar Dan Carpenter Committed by Tomi Valkeinen

video: mmpfb: cleanup some static checker warnings in probe()

Sparse complains about using zero instead of NULL for pointers.
Probably, if we enabled the warning, then GCC would complain about the
unused initializers.  I've just removed them.

Smatch complains that we first check if "fbi" is NULL and then
dereference it in the error handling.  It turns out that "fbi" can't be
NULL so I've removed the check.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent c150a280
...@@ -554,8 +554,8 @@ static void fb_info_clear(struct fb_info *info) ...@@ -554,8 +554,8 @@ static void fb_info_clear(struct fb_info *info)
static int mmpfb_probe(struct platform_device *pdev) static int mmpfb_probe(struct platform_device *pdev)
{ {
struct mmp_buffer_driver_mach_info *mi; struct mmp_buffer_driver_mach_info *mi;
struct fb_info *info = 0; struct fb_info *info;
struct mmpfb_info *fbi = 0; struct mmpfb_info *fbi;
int ret, modes_num; int ret, modes_num;
mi = pdev->dev.platform_data; mi = pdev->dev.platform_data;
...@@ -569,10 +569,6 @@ static int mmpfb_probe(struct platform_device *pdev) ...@@ -569,10 +569,6 @@ static int mmpfb_probe(struct platform_device *pdev)
if (info == NULL) if (info == NULL)
return -ENOMEM; return -ENOMEM;
fbi = info->par; fbi = info->par;
if (!fbi) {
ret = -EINVAL;
goto failed;
}
/* init fb */ /* init fb */
fbi->fb_info = info; fbi->fb_info = info;
...@@ -667,7 +663,6 @@ static int mmpfb_probe(struct platform_device *pdev) ...@@ -667,7 +663,6 @@ static int mmpfb_probe(struct platform_device *pdev)
fbi->fb_start_dma); fbi->fb_start_dma);
failed_destroy_mutex: failed_destroy_mutex:
mutex_destroy(&fbi->access_ok); mutex_destroy(&fbi->access_ok);
failed:
dev_err(fbi->dev, "mmp-fb: frame buffer device init failed\n"); dev_err(fbi->dev, "mmp-fb: frame buffer device init failed\n");
framebuffer_release(info); framebuffer_release(info);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment