Commit a63b22bb authored by David Woodhouse's avatar David Woodhouse Committed by David S. Miller

libertas: use lbs_host_to_card_done() in lbs_tx_timeout()

Also attempt some locking in lbs_host_to_card_done()
Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent aa21c004
...@@ -601,31 +601,24 @@ static void lbs_tx_timeout(struct net_device *dev) ...@@ -601,31 +601,24 @@ static void lbs_tx_timeout(struct net_device *dev)
lbs_pr_err("tx watch dog timeout\n"); lbs_pr_err("tx watch dog timeout\n");
priv->dnld_sent = DNLD_RES_RECEIVED;
dev->trans_start = jiffies; dev->trans_start = jiffies;
if (priv->currenttxskb) { if (priv->currenttxskb) {
if (priv->monitormode != LBS_MONITOR_OFF) { priv->eventcause = 0x01000000;
/* If we are here, we have not received feedback from lbs_send_tx_feedback(priv);
the previous packet. Assume TX_FAIL and move on. */
priv->eventcause = 0x01000000;
lbs_send_tx_feedback(priv);
} else
wake_up_interruptible(&priv->waitq);
} else if (dev == priv->dev) {
if (priv->connect_status == LBS_CONNECTED)
netif_wake_queue(priv->dev);
} else if (dev == priv->mesh_dev) {
if (priv->mesh_connect_status == LBS_CONNECTED)
netif_wake_queue(priv->mesh_dev);
} }
/* XX: Shouldn't we also call into the hw-specific driver
to kick it somehow? */
lbs_host_to_card_done(priv);
lbs_deb_leave(LBS_DEB_TX); lbs_deb_leave(LBS_DEB_TX);
} }
void lbs_host_to_card_done(struct lbs_private *priv) void lbs_host_to_card_done(struct lbs_private *priv)
{ {
unsigned long flags;
spin_lock_irqsave(&priv->driver_lock, flags);
priv->dnld_sent = DNLD_RES_RECEIVED; priv->dnld_sent = DNLD_RES_RECEIVED;
...@@ -634,15 +627,16 @@ void lbs_host_to_card_done(struct lbs_private *priv) ...@@ -634,15 +627,16 @@ void lbs_host_to_card_done(struct lbs_private *priv)
wake_up_interruptible(&priv->waitq); wake_up_interruptible(&priv->waitq);
/* Don't wake netif queues if we're in monitor mode and /* Don't wake netif queues if we're in monitor mode and
a TX packet is already pending. */ a TX packet is already pending, or if there are commands
if (priv->currenttxskb) queued to be sent. */
return; if (!priv->currenttxskb && list_empty(&priv->cmdpendingq)) {
if (priv->dev && priv->connect_status == LBS_CONNECTED)
if (priv->dev && priv->connect_status == LBS_CONNECTED) netif_wake_queue(priv->dev);
netif_wake_queue(priv->dev);
if (priv->mesh_dev && priv->mesh_connect_status == LBS_CONNECTED) if (priv->mesh_dev && priv->mesh_connect_status == LBS_CONNECTED)
netif_wake_queue(priv->mesh_dev); netif_wake_queue(priv->mesh_dev);
}
spin_unlock_irqrestore(&priv->driver_lock, flags);
} }
EXPORT_SYMBOL_GPL(lbs_host_to_card_done); EXPORT_SYMBOL_GPL(lbs_host_to_card_done);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment