Commit a650628b authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe

block: move submit_bio_checks() into submit_bio_noacct

It is more clean & readable to check bio when starting to submit it,
instead of just before calling ->submit_bio() or blk_mq_submit_bio().

Also it provides us chance to optimize bio submission without checking
bio.
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220216044514.2903784-2-ming.lei@redhat.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9f9adea7
...@@ -797,9 +797,6 @@ static void __submit_bio(struct bio *bio) ...@@ -797,9 +797,6 @@ static void __submit_bio(struct bio *bio)
{ {
struct gendisk *disk = bio->bi_bdev->bd_disk; struct gendisk *disk = bio->bi_bdev->bd_disk;
if (unlikely(!submit_bio_checks(bio)))
return;
if (!disk->fops->submit_bio) if (!disk->fops->submit_bio)
blk_mq_submit_bio(bio); blk_mq_submit_bio(bio);
else else
...@@ -893,6 +890,9 @@ static void __submit_bio_noacct_mq(struct bio *bio) ...@@ -893,6 +890,9 @@ static void __submit_bio_noacct_mq(struct bio *bio)
*/ */
void submit_bio_noacct(struct bio *bio) void submit_bio_noacct(struct bio *bio)
{ {
if (unlikely(!submit_bio_checks(bio)))
return;
/* /*
* We only want one ->submit_bio to be active at a time, else stack * We only want one ->submit_bio to be active at a time, else stack
* usage with stacked devices could be a problem. Use current->bio_list * usage with stacked devices could be a problem. Use current->bio_list
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment