Commit a6bcfc89 authored by Li RongQing's avatar Li RongQing Committed by David S. Miller

net: check extack._msg before print

dev_set_mtu_ext is able to fail with a valid mtu value, at that
condition, extack._msg is not set and random since it is in stack,
then kernel will crash when print it.

Fixes: 7a4c53be ("net: report invalid mtu value via netlink extack")
Signed-off-by: default avatarZhang Yu <zhangyu31@baidu.com>
Signed-off-by: default avatarLi RongQing <lirongqing@baidu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0ed4229b
...@@ -7583,8 +7583,9 @@ int dev_set_mtu(struct net_device *dev, int new_mtu) ...@@ -7583,8 +7583,9 @@ int dev_set_mtu(struct net_device *dev, int new_mtu)
struct netlink_ext_ack extack; struct netlink_ext_ack extack;
int err; int err;
memset(&extack, 0, sizeof(extack));
err = dev_set_mtu_ext(dev, new_mtu, &extack); err = dev_set_mtu_ext(dev, new_mtu, &extack);
if (err) if (err && extack._msg)
net_err_ratelimited("%s: %s\n", dev->name, extack._msg); net_err_ratelimited("%s: %s\n", dev->name, extack._msg);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment