Commit a6e757e3 authored by Jiri Kosina's avatar Jiri Kosina

Merge branch 'for-5.16/amd-sfh' into for-linus

- code cleanups (Basavaraj Natikar, Christophe JAILLET)
parents 43775e62 f75203cd
// SPDX-License-Identifier: GPL-2.0-or-later // SPDX-License-Identifier: GPL-2.0-or-later
/* /*
* AMD SFH Client Layer * AMD SFH Client Layer
* Copyright 2020 Advanced Micro Devices, Inc. * Copyright 2020-2021 Advanced Micro Devices, Inc.
* Authors: Nehal Bakulchandra Shah <Nehal-Bakulchandra.Shah@amd.com> * Authors: Nehal Bakulchandra Shah <Nehal-Bakulchandra.Shah@amd.com>
* Sandeep Singh <Sandeep.singh@amd.com> * Sandeep Singh <Sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#include <linux/dma-mapping.h> #include <linux/dma-mapping.h>
......
...@@ -2,8 +2,10 @@ ...@@ -2,8 +2,10 @@
/* /*
* AMD MP2 Sensors transport driver * AMD MP2 Sensors transport driver
* *
* Copyright 2020-2021 Advanced Micro Devices, Inc.
* Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com> * Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com>
* Sandeep Singh <sandeep.singh@amd.com> * Sandeep Singh <sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#include <linux/hid.h> #include <linux/hid.h>
#include <linux/wait.h> #include <linux/wait.h>
......
...@@ -2,8 +2,10 @@ ...@@ -2,8 +2,10 @@
/* /*
* AMD MP2 Sensors transport driver * AMD MP2 Sensors transport driver
* *
* Copyright 2020-2021 Advanced Micro Devices, Inc.
* Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com> * Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com>
* Sandeep Singh <sandeep.singh@amd.com> * Sandeep Singh <sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#ifndef AMDSFH_HID_H #ifndef AMDSFH_HID_H
......
// SPDX-License-Identifier: GPL-2.0-or-later // SPDX-License-Identifier: GPL-2.0-or-later
/* /*
* AMD MP2 PCIe communication driver * AMD MP2 PCIe communication driver
* Copyright 2020 Advanced Micro Devices, Inc. * Copyright 2020-2021 Advanced Micro Devices, Inc.
* *
* Authors: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> * Authors: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
* Sandeep Singh <Sandeep.singh@amd.com> * Sandeep Singh <Sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#include <linux/bitops.h> #include <linux/bitops.h>
...@@ -234,7 +235,7 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i ...@@ -234,7 +235,7 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
return -ENOMEM; return -ENOMEM;
privdata->pdev = pdev; privdata->pdev = pdev;
pci_set_drvdata(pdev, privdata); dev_set_drvdata(&pdev->dev, privdata);
rc = pcim_enable_device(pdev); rc = pcim_enable_device(pdev);
if (rc) if (rc)
return rc; return rc;
...@@ -245,10 +246,13 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i ...@@ -245,10 +246,13 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
privdata->mmio = pcim_iomap_table(pdev)[2]; privdata->mmio = pcim_iomap_table(pdev)[2];
pci_set_master(pdev); pci_set_master(pdev);
rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(64)); rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
if (rc) { if (rc) {
rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
return rc; if (rc) {
dev_err(&pdev->dev, "failed to set DMA mask\n");
return rc;
}
} }
privdata->cl_data = devm_kzalloc(&pdev->dev, sizeof(struct amdtp_cl_data), GFP_KERNEL); privdata->cl_data = devm_kzalloc(&pdev->dev, sizeof(struct amdtp_cl_data), GFP_KERNEL);
...@@ -266,8 +270,7 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i ...@@ -266,8 +270,7 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
static int __maybe_unused amd_mp2_pci_resume(struct device *dev) static int __maybe_unused amd_mp2_pci_resume(struct device *dev)
{ {
struct pci_dev *pdev = to_pci_dev(dev); struct amd_mp2_dev *mp2 = dev_get_drvdata(dev);
struct amd_mp2_dev *mp2 = pci_get_drvdata(pdev);
struct amdtp_cl_data *cl_data = mp2->cl_data; struct amdtp_cl_data *cl_data = mp2->cl_data;
struct amd_mp2_sensor_info info; struct amd_mp2_sensor_info info;
int i, status; int i, status;
...@@ -292,8 +295,7 @@ static int __maybe_unused amd_mp2_pci_resume(struct device *dev) ...@@ -292,8 +295,7 @@ static int __maybe_unused amd_mp2_pci_resume(struct device *dev)
static int __maybe_unused amd_mp2_pci_suspend(struct device *dev) static int __maybe_unused amd_mp2_pci_suspend(struct device *dev)
{ {
struct pci_dev *pdev = to_pci_dev(dev); struct amd_mp2_dev *mp2 = dev_get_drvdata(dev);
struct amd_mp2_dev *mp2 = pci_get_drvdata(pdev);
struct amdtp_cl_data *cl_data = mp2->cl_data; struct amdtp_cl_data *cl_data = mp2->cl_data;
int i, status; int i, status;
...@@ -334,3 +336,4 @@ MODULE_DESCRIPTION(DRIVER_DESC); ...@@ -334,3 +336,4 @@ MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("Dual BSD/GPL"); MODULE_LICENSE("Dual BSD/GPL");
MODULE_AUTHOR("Shyam Sundar S K <Shyam-sundar.S-k@amd.com>"); MODULE_AUTHOR("Shyam Sundar S K <Shyam-sundar.S-k@amd.com>");
MODULE_AUTHOR("Sandeep Singh <Sandeep.singh@amd.com>"); MODULE_AUTHOR("Sandeep Singh <Sandeep.singh@amd.com>");
MODULE_AUTHOR("Basavaraj Natikar <Basavaraj.Natikar@amd.com>");
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
/* /*
* AMD MP2 PCIe communication driver * AMD MP2 PCIe communication driver
* Copyright 2020 Advanced Micro Devices, Inc. * Copyright 2020-2021 Advanced Micro Devices, Inc.
* Authors: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> * Authors: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
* Sandeep Singh <Sandeep.singh@amd.com> * Sandeep Singh <Sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#ifndef PCIE_MP2_AMD_H #ifndef PCIE_MP2_AMD_H
......
// SPDX-License-Identifier: GPL-2.0-or-later // SPDX-License-Identifier: GPL-2.0-or-later
/* /*
* AMD SFH Report Descriptor generator * AMD SFH Report Descriptor generator
* Copyright 2020 Advanced Micro Devices, Inc. * Copyright 2020-2021 Advanced Micro Devices, Inc.
* Authors: Nehal Bakulchandra Shah <Nehal-Bakulchandra.Shah@amd.com> * Authors: Nehal Bakulchandra Shah <Nehal-Bakulchandra.Shah@amd.com>
* Sandeep Singh <sandeep.singh@amd.com> * Sandeep Singh <sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#include <linux/kernel.h> #include <linux/kernel.h>
......
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
/* /*
* HID report descriptors, structures and routines * HID report descriptors, structures and routines
* Copyright 2020 Advanced Micro Devices, Inc. * Copyright 2020-2021 Advanced Micro Devices, Inc.
* Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com> * Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com>
* Sandeep Singh <Sandeep.singh@amd.com> * Sandeep Singh <Sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#ifndef AMD_SFH_HID_DESCRIPTOR_H #ifndef AMD_SFH_HID_DESCRIPTOR_H
......
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
/* /*
* HID descriptor stuructures * HID descriptor stuructures
* Copyright 2020 Advanced Micro Devices, Inc. * Copyright 2020-2021 Advanced Micro Devices, Inc.
* Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com> * Authors: Nehal Bakulchandra Shah <Nehal-bakulchandra.shah@amd.com>
* Sandeep Singh <Sandeep.singh@amd.com> * Sandeep Singh <Sandeep.singh@amd.com>
* Basavaraj Natikar <Basavaraj.Natikar@amd.com>
*/ */
#ifndef AMD_SFH_HID_REPORT_DESCRIPTOR_H #ifndef AMD_SFH_HID_REPORT_DESCRIPTOR_H
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment