Commit a74eaf16 authored by David Ahern's avatar David Ahern Committed by Arnaldo Carvalho de Melo

perf sched timehist: Fix use of CPU list with summary option

Do not update thread stats or show idle summary unless CPU is in the
list of interest.

Fixes: c30d630d ("perf sched timehist: Add support for filtering on CPU")
Signed-off-by: default avatarDavid Ahern <dsahern@kernel.org>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lore.kernel.org/lkml/20200817170943.1486-1-dsahern@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 4b04e0de
...@@ -2584,7 +2584,8 @@ static int timehist_sched_change_event(struct perf_tool *tool, ...@@ -2584,7 +2584,8 @@ static int timehist_sched_change_event(struct perf_tool *tool,
} }
if (!sched->idle_hist || thread->tid == 0) { if (!sched->idle_hist || thread->tid == 0) {
timehist_update_runtime_stats(tr, t, tprev); if (!cpu_list || test_bit(sample->cpu, cpu_bitmap))
timehist_update_runtime_stats(tr, t, tprev);
if (sched->idle_hist) { if (sched->idle_hist) {
struct idle_thread_runtime *itr = (void *)tr; struct idle_thread_runtime *itr = (void *)tr;
...@@ -2857,6 +2858,9 @@ static void timehist_print_summary(struct perf_sched *sched, ...@@ -2857,6 +2858,9 @@ static void timehist_print_summary(struct perf_sched *sched,
printf("\nIdle stats:\n"); printf("\nIdle stats:\n");
for (i = 0; i < idle_max_cpu; ++i) { for (i = 0; i < idle_max_cpu; ++i) {
if (cpu_list && !test_bit(i, cpu_bitmap))
continue;
t = idle_threads[i]; t = idle_threads[i];
if (!t) if (!t)
continue; continue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment