Commit a7503a9d authored by Robin Gong's avatar Robin Gong Committed by Mark Brown

regulator: pfuze100: add condition check for 'ramp_delay = 0'

Checking for 'ramp_delay = 0' to avoid Coverity warning report.
Signed-off-by: default avatarRobin Gong <yibin.gong@nxp.com>
Link: https://lore.kernel.org/r/1592920870-12693-1-git-send-email-yibin.gong@nxp.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9ed84d24
...@@ -128,7 +128,7 @@ static int pfuze100_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) ...@@ -128,7 +128,7 @@ static int pfuze100_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
struct pfuze_chip *pfuze100 = rdev_get_drvdata(rdev); struct pfuze_chip *pfuze100 = rdev_get_drvdata(rdev);
int id = rdev_get_id(rdev); int id = rdev_get_id(rdev);
bool reg_has_ramp_delay; bool reg_has_ramp_delay;
unsigned int ramp_bits; unsigned int ramp_bits = 0;
int ret; int ret;
switch (pfuze100->chip_id) { switch (pfuze100->chip_id) {
...@@ -149,8 +149,11 @@ static int pfuze100_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) ...@@ -149,8 +149,11 @@ static int pfuze100_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
} }
if (reg_has_ramp_delay) { if (reg_has_ramp_delay) {
ramp_delay = 12500 / ramp_delay; if (ramp_delay > 0) {
ramp_bits = (ramp_delay >> 1) - (ramp_delay >> 3); ramp_delay = 12500 / ramp_delay;
ramp_bits = (ramp_delay >> 1) - (ramp_delay >> 3);
}
ret = regmap_update_bits(pfuze100->regmap, ret = regmap_update_bits(pfuze100->regmap,
rdev->desc->vsel_reg + 4, rdev->desc->vsel_reg + 4,
0xc0, ramp_bits << 6); 0xc0, ramp_bits << 6);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment