Commit a844d1ef authored by Srikar Dronamraju's avatar Srikar Dronamraju Committed by Arnaldo Carvalho de Melo

perf probe: Usability fixes

Ingo pointed out few perf probe usability related errors during his
review of uprobes.

Since these issues are independent of uprobes, fixing them in a separate
patch.
Suggested-by: default avatarIngo Molnar <mingo@elte.hu>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Link: http://lkml.kernel.org/r/20120120121354.GL15447@linux.vnet.ibm.comSigned-off-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 2ef1ea38
...@@ -1729,7 +1729,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev, ...@@ -1729,7 +1729,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
} }
ret = 0; ret = 0;
printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":"); printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":");
for (i = 0; i < ntevs; i++) { for (i = 0; i < ntevs; i++) {
tev = &tevs[i]; tev = &tevs[i];
if (pev->event) if (pev->event)
...@@ -1784,7 +1784,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev, ...@@ -1784,7 +1784,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
if (ret >= 0) { if (ret >= 0) {
/* Show how to use the event. */ /* Show how to use the event. */
printf("\nYou can now use it on all perf tools, such as:\n\n"); printf("\nYou can now use it in all perf tools, such as:\n\n");
printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group, printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group,
tev->event); tev->event);
} }
...@@ -1959,7 +1959,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent) ...@@ -1959,7 +1959,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent)
goto error; goto error;
} }
printf("Remove event: %s\n", ent->s); printf("Removed event: %s\n", ent->s);
return 0; return 0;
error: error:
pr_warning("Failed to delete event: %s\n", strerror(-ret)); pr_warning("Failed to delete event: %s\n", strerror(-ret));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment