Commit a87852e3 authored by Jonas Karlman's avatar Jonas Karlman Committed by Heiko Stuebner

arm64: dts: rockchip: Fix PCIe regulators on Radxa E25

Despite its name, the regulator vcc3v3_pcie30x1 has nothing to do with
pcie30x1. Instead, it supply power to VBAT1-5 on the M.2 KEY B port as
seen on page 8 of the schematic [1].

pcie30x1 is used for the mini PCIe slot, and as seen on page 9 the
vcc3v3_minipcie regulator is instead related to pcie30x1.

The M.2 KEY B port can be used for WWAN USB2 modules or SATA drives.

Use correct regulator vcc3v3_minipcie for pcie30x1.

[1] https://dl.radxa.com/cm3p/e25/radxa-e25-v1.4-sch.pdf

Fixes: 2bf2f4d9 ("arm64: dts: rockchip: Add Radxa CM3I E25")
Signed-off-by: default avatarJonas Karlman <jonas@kwiboo.se>
Link: https://lore.kernel.org/r/20230724145213.3833099-1-jonas@kwiboo.seSigned-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent a02913e8
...@@ -47,6 +47,9 @@ vbus_typec: vbus-typec-regulator { ...@@ -47,6 +47,9 @@ vbus_typec: vbus-typec-regulator {
vin-supply = <&vcc5v0_sys>; vin-supply = <&vcc5v0_sys>;
}; };
/* actually fed by vcc5v0_sys, dependent
* on pi6c clock generator
*/
vcc3v3_minipcie: vcc3v3-minipcie-regulator { vcc3v3_minipcie: vcc3v3-minipcie-regulator {
compatible = "regulator-fixed"; compatible = "regulator-fixed";
enable-active-high; enable-active-high;
...@@ -54,9 +57,9 @@ vcc3v3_minipcie: vcc3v3-minipcie-regulator { ...@@ -54,9 +57,9 @@ vcc3v3_minipcie: vcc3v3-minipcie-regulator {
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&minipcie_enable_h>; pinctrl-0 = <&minipcie_enable_h>;
regulator-name = "vcc3v3_minipcie"; regulator-name = "vcc3v3_minipcie";
regulator-min-microvolt = <5000000>; regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <5000000>; regulator-max-microvolt = <3300000>;
vin-supply = <&vcc5v0_sys>; vin-supply = <&vcc3v3_pi6c_05>;
}; };
vcc3v3_ngff: vcc3v3-ngff-regulator { vcc3v3_ngff: vcc3v3-ngff-regulator {
...@@ -71,9 +74,6 @@ vcc3v3_ngff: vcc3v3-ngff-regulator { ...@@ -71,9 +74,6 @@ vcc3v3_ngff: vcc3v3-ngff-regulator {
vin-supply = <&vcc5v0_sys>; vin-supply = <&vcc5v0_sys>;
}; };
/* actually fed by vcc5v0_sys, dependent
* on pi6c clock generator
*/
vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator { vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
compatible = "regulator-fixed"; compatible = "regulator-fixed";
enable-active-high; enable-active-high;
...@@ -83,7 +83,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator { ...@@ -83,7 +83,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
regulator-name = "vcc3v3_pcie30x1"; regulator-name = "vcc3v3_pcie30x1";
regulator-min-microvolt = <3300000>; regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>; regulator-max-microvolt = <3300000>;
vin-supply = <&vcc3v3_pi6c_05>; vin-supply = <&vcc5v0_sys>;
}; };
vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator { vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
...@@ -117,7 +117,7 @@ &pcie3x1 { ...@@ -117,7 +117,7 @@ &pcie3x1 {
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&pcie30x1m0_pins>; pinctrl-0 = <&pcie30x1m0_pins>;
reset-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>;
vpcie3v3-supply = <&vcc3v3_pcie30x1>; vpcie3v3-supply = <&vcc3v3_minipcie>;
status = "okay"; status = "okay";
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment