Commit a9007054 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai

ALSA: firewire-lib: use protocol error when detecting wrong value in CIP header

When detecting zero in 'dbs' field of CIP header, this packet streaming
should be aborted because of avoiding division-by-zero. This is an error
in an aspect of IEC 61883-1, thus protocol error.

This commit use EPROTO instead of EIO. Actually, the returned value is
not used for userspace and this commit has no effect.
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 12e0f438
...@@ -726,7 +726,7 @@ static int handle_in_packet(struct amdtp_stream *s, ...@@ -726,7 +726,7 @@ static int handle_in_packet(struct amdtp_stream *s,
dev_err(&s->unit->device, dev_err(&s->unit->device,
"Detect invalid value in dbs field: %08X\n", "Detect invalid value in dbs field: %08X\n",
cip_header[0]); cip_header[0]);
return -EIO; return -EPROTO;
} }
if (s->flags & CIP_WRONG_DBS) if (s->flags & CIP_WRONG_DBS)
data_block_quadlets = s->data_block_quadlets; data_block_quadlets = s->data_block_quadlets;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment