Commit a906331c authored by Simon Ser's avatar Simon Ser Committed by Alex Deucher

amd/display: downgrade validation failure log level

In amdgpu_dm_atomic_check, dc_validate_global_state is called. On
failure this logs a warning to the kernel journal. However warnings
shouldn't be used for atomic test-only commit failures: user-space
might be perfoming a lot of atomic test-only commits to find the
best hardware configuration.

Downgrade the log to a regular DRM atomic message. While at it, use
the new device-aware logging infrastructure.

This fixes error messages in the kernel when running gamescope [1].

[1]: https://github.com/Plagman/gamescope/issues/245Reviewed-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 67684fcb
...@@ -10653,7 +10653,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev, ...@@ -10653,7 +10653,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
goto fail; goto fail;
status = dc_validate_global_state(dc, dm_state->context, false); status = dc_validate_global_state(dc, dm_state->context, false);
if (status != DC_OK) { if (status != DC_OK) {
DC_LOG_WARNING("DC global validation failure: %s (%d)", drm_dbg_atomic(dev,
"DC global validation failure: %s (%d)",
dc_status_to_str(status), status); dc_status_to_str(status), status);
ret = -EINVAL; ret = -EINVAL;
goto fail; goto fail;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment