Commit a924eae7 authored by Yash Shah's avatar Yash Shah Committed by Linus Walleij

gpio: sifive: fix static checker warning

Typcasting "irq_state" leads to the below static checker warning:
The fix is to declare "irq_state" as unsigned long instead of u32.

	drivers/gpio/gpio-sifive.c:97 sifive_gpio_irq_enable()
	warn: passing casted pointer '&chip->irq_state' to
	'assign_bit()' 32 vs 64.

Fixes: 96868dce ("gpio/sifive: Add GPIO driver for SiFive SoCs")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarYash Shah <yash.shah@sifive.com>
Link: https://lore.kernel.org/r/1580189061-14091-1-git-send-email-yash.shah@sifive.comReviewed-by: default avatarMarc Zyngier <maz@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 2d5a2f91
...@@ -35,7 +35,7 @@ struct sifive_gpio { ...@@ -35,7 +35,7 @@ struct sifive_gpio {
void __iomem *base; void __iomem *base;
struct gpio_chip gc; struct gpio_chip gc;
struct regmap *regs; struct regmap *regs;
u32 irq_state; unsigned long irq_state;
unsigned int trigger[SIFIVE_GPIO_MAX]; unsigned int trigger[SIFIVE_GPIO_MAX];
unsigned int irq_parent[SIFIVE_GPIO_MAX]; unsigned int irq_parent[SIFIVE_GPIO_MAX];
}; };
...@@ -94,7 +94,7 @@ static void sifive_gpio_irq_enable(struct irq_data *d) ...@@ -94,7 +94,7 @@ static void sifive_gpio_irq_enable(struct irq_data *d)
spin_unlock_irqrestore(&gc->bgpio_lock, flags); spin_unlock_irqrestore(&gc->bgpio_lock, flags);
/* Enable interrupts */ /* Enable interrupts */
assign_bit(offset, (unsigned long *)&chip->irq_state, 1); assign_bit(offset, &chip->irq_state, 1);
sifive_gpio_set_ie(chip, offset); sifive_gpio_set_ie(chip, offset);
} }
...@@ -104,7 +104,7 @@ static void sifive_gpio_irq_disable(struct irq_data *d) ...@@ -104,7 +104,7 @@ static void sifive_gpio_irq_disable(struct irq_data *d)
struct sifive_gpio *chip = gpiochip_get_data(gc); struct sifive_gpio *chip = gpiochip_get_data(gc);
int offset = irqd_to_hwirq(d) % SIFIVE_GPIO_MAX; int offset = irqd_to_hwirq(d) % SIFIVE_GPIO_MAX;
assign_bit(offset, (unsigned long *)&chip->irq_state, 0); assign_bit(offset, &chip->irq_state, 0);
sifive_gpio_set_ie(chip, offset); sifive_gpio_set_ie(chip, offset);
irq_chip_disable_parent(d); irq_chip_disable_parent(d);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment