Commit aa1dcb56 authored by Dmitry Bogdanov's avatar Dmitry Bogdanov Committed by David S. Miller

atlantic: Increase delay for fw transactions

The max waiting period (of 1 ms) while reading the data from FW shared
buffer is too small for certain types of data (e.g., stats). There's a
chance that FW could be updating buffer at the same time and driver
would be unsuccessful in reading data. Firmware manual recommends to
have 1 sec timeout to fix this issue.

Fixes: 5cfd54d7 ("net: atlantic: minimal A2 fw_ops")
Signed-off-by: default avatarDmitry Bogdanov <dbezrukov@marvell.com>
Signed-off-by: default avatarSudarsana Reddy Kalluru <skalluru@marvell.com>
Signed-off-by: default avatarIgor Russkikh <irusskikh@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2191b1df
...@@ -84,7 +84,7 @@ static int hw_atl2_shared_buffer_read_block(struct aq_hw_s *self, ...@@ -84,7 +84,7 @@ static int hw_atl2_shared_buffer_read_block(struct aq_hw_s *self,
if (cnt > AQ_A2_FW_READ_TRY_MAX) if (cnt > AQ_A2_FW_READ_TRY_MAX)
return -ETIME; return -ETIME;
if (tid1.transaction_cnt_a != tid1.transaction_cnt_b) if (tid1.transaction_cnt_a != tid1.transaction_cnt_b)
udelay(1); mdelay(1);
} while (tid1.transaction_cnt_a != tid1.transaction_cnt_b); } while (tid1.transaction_cnt_a != tid1.transaction_cnt_b);
hw_atl2_mif_shared_buf_read(self, offset, (u32 *)data, dwords); hw_atl2_mif_shared_buf_read(self, offset, (u32 *)data, dwords);
...@@ -339,8 +339,11 @@ static int aq_a2_fw_update_stats(struct aq_hw_s *self) ...@@ -339,8 +339,11 @@ static int aq_a2_fw_update_stats(struct aq_hw_s *self)
{ {
struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv; struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv;
struct statistics_s stats; struct statistics_s stats;
int err;
hw_atl2_shared_buffer_read_safe(self, stats, &stats); err = hw_atl2_shared_buffer_read_safe(self, stats, &stats);
if (err)
return err;
#define AQ_SDELTA(_N_, _F_) (self->curr_stats._N_ += \ #define AQ_SDELTA(_N_, _F_) (self->curr_stats._N_ += \
stats.msm._F_ - priv->last_stats.msm._F_) stats.msm._F_ - priv->last_stats.msm._F_)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment