Commit aa3d586e authored by Jani Nikula's avatar Jani Nikula

drm/i915/pciids: don't include WHL/CML PCI IDs in CFL

It's confusing for INTEL_CFL_IDS() to include all WHL and CML PCI
IDs. Even if we treat them the same in a lot of places, CML is a
platform of its own, and the lists of PCI IDs should not conflate them.

Largely go by the idea that if a platform has a name, group its PCI IDs
together.

That said, AML is special, having both KBL and CFL variants. Leave that
alone.

v2: Also split out WHL not just CML (Rodrigo)

Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://patchwork.freedesktop.org/patch/msgid/7cca91dc78ed2b5982f14e400f03a1704645e475.1715340032.git.jani.nikula@intel.comSigned-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 5c8c22ad
...@@ -543,6 +543,8 @@ static const struct pci_device_id intel_early_ids[] __initconst = { ...@@ -543,6 +543,8 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
INTEL_BXT_IDS(&gen9_early_ops), INTEL_BXT_IDS(&gen9_early_ops),
INTEL_KBL_IDS(&gen9_early_ops), INTEL_KBL_IDS(&gen9_early_ops),
INTEL_CFL_IDS(&gen9_early_ops), INTEL_CFL_IDS(&gen9_early_ops),
INTEL_WHL_IDS(&gen9_early_ops),
INTEL_CML_IDS(&gen9_early_ops),
INTEL_GLK_IDS(&gen9_early_ops), INTEL_GLK_IDS(&gen9_early_ops),
INTEL_CNL_IDS(&gen9_early_ops), INTEL_CNL_IDS(&gen9_early_ops),
INTEL_ICL_11_IDS(&gen11_early_ops), INTEL_ICL_11_IDS(&gen11_early_ops),
......
...@@ -829,6 +829,8 @@ static const struct { ...@@ -829,6 +829,8 @@ static const struct {
INTEL_GLK_IDS(&glk_display), INTEL_GLK_IDS(&glk_display),
INTEL_KBL_IDS(&skl_display), INTEL_KBL_IDS(&skl_display),
INTEL_CFL_IDS(&skl_display), INTEL_CFL_IDS(&skl_display),
INTEL_WHL_IDS(&skl_display),
INTEL_CML_IDS(&skl_display),
INTEL_ICL_11_IDS(&icl_display), INTEL_ICL_11_IDS(&icl_display),
INTEL_EHL_IDS(&jsl_ehl_display), INTEL_EHL_IDS(&jsl_ehl_display),
INTEL_JSL_IDS(&jsl_ehl_display), INTEL_JSL_IDS(&jsl_ehl_display),
......
...@@ -488,6 +488,12 @@ ...@@ -488,6 +488,12 @@
INTEL_VGA_DEVICE(0x9BCA, info), \ INTEL_VGA_DEVICE(0x9BCA, info), \
INTEL_VGA_DEVICE(0x9BCC, info) INTEL_VGA_DEVICE(0x9BCC, info)
#define INTEL_CML_IDS(info) \
INTEL_CML_GT1_IDS(info), \
INTEL_CML_GT2_IDS(info), \
INTEL_CML_U_GT1_IDS(info), \
INTEL_CML_U_GT2_IDS(info)
#define INTEL_KBL_IDS(info) \ #define INTEL_KBL_IDS(info) \
INTEL_KBL_GT1_IDS(info), \ INTEL_KBL_GT1_IDS(info), \
INTEL_KBL_GT2_IDS(info), \ INTEL_KBL_GT2_IDS(info), \
...@@ -527,6 +533,15 @@ ...@@ -527,6 +533,15 @@
INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \ INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */ INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
#define INTEL_CFL_IDS(info) \
INTEL_CFL_S_GT1_IDS(info), \
INTEL_CFL_S_GT2_IDS(info), \
INTEL_CFL_H_GT1_IDS(info), \
INTEL_CFL_H_GT2_IDS(info), \
INTEL_CFL_U_GT2_IDS(info), \
INTEL_CFL_U_GT3_IDS(info), \
INTEL_AML_CFL_GT2_IDS(info)
/* WHL/CFL U GT1 */ /* WHL/CFL U GT1 */
#define INTEL_WHL_U_GT1_IDS(info) \ #define INTEL_WHL_U_GT1_IDS(info) \
INTEL_VGA_DEVICE(0x3EA1, info), \ INTEL_VGA_DEVICE(0x3EA1, info), \
...@@ -541,21 +556,10 @@ ...@@ -541,21 +556,10 @@
#define INTEL_WHL_U_GT3_IDS(info) \ #define INTEL_WHL_U_GT3_IDS(info) \
INTEL_VGA_DEVICE(0x3EA2, info) INTEL_VGA_DEVICE(0x3EA2, info)
#define INTEL_CFL_IDS(info) \ #define INTEL_WHL_IDS(info) \
INTEL_CFL_S_GT1_IDS(info), \
INTEL_CFL_S_GT2_IDS(info), \
INTEL_CFL_H_GT1_IDS(info), \
INTEL_CFL_H_GT2_IDS(info), \
INTEL_CFL_U_GT2_IDS(info), \
INTEL_CFL_U_GT3_IDS(info), \
INTEL_WHL_U_GT1_IDS(info), \ INTEL_WHL_U_GT1_IDS(info), \
INTEL_WHL_U_GT2_IDS(info), \ INTEL_WHL_U_GT2_IDS(info), \
INTEL_WHL_U_GT3_IDS(info), \ INTEL_WHL_U_GT3_IDS(info)
INTEL_AML_CFL_GT2_IDS(info), \
INTEL_CML_GT1_IDS(info), \
INTEL_CML_GT2_IDS(info), \
INTEL_CML_U_GT1_IDS(info), \
INTEL_CML_U_GT2_IDS(info)
/* CNL */ /* CNL */
#define INTEL_CNL_PORT_F_IDS(info) \ #define INTEL_CNL_PORT_F_IDS(info) \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment