Commit ab4e8fc1 authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe

RDMA/irdma: Return void from irdma_init_iw_device()

The return value from irdma_init_iw_device() is always 0 - change it to be
void.

Link: https://lore.kernel.org/r/20230515191142.413633-2-kheib@redhat.comSigned-off-by: default avatarKamal Heib <kheib@redhat.com>
Reviewed-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 9b4b7c1f
...@@ -4515,7 +4515,7 @@ static void irdma_init_roce_device(struct irdma_device *iwdev) ...@@ -4515,7 +4515,7 @@ static void irdma_init_roce_device(struct irdma_device *iwdev)
* irdma_init_iw_device - initialization of iwarp rdma device * irdma_init_iw_device - initialization of iwarp rdma device
* @iwdev: irdma device * @iwdev: irdma device
*/ */
static int irdma_init_iw_device(struct irdma_device *iwdev) static void irdma_init_iw_device(struct irdma_device *iwdev)
{ {
struct net_device *netdev = iwdev->netdev; struct net_device *netdev = iwdev->netdev;
...@@ -4533,8 +4533,6 @@ static int irdma_init_iw_device(struct irdma_device *iwdev) ...@@ -4533,8 +4533,6 @@ static int irdma_init_iw_device(struct irdma_device *iwdev)
memcpy(iwdev->ibdev.iw_ifname, netdev->name, memcpy(iwdev->ibdev.iw_ifname, netdev->name,
sizeof(iwdev->ibdev.iw_ifname)); sizeof(iwdev->ibdev.iw_ifname));
ib_set_device_ops(&iwdev->ibdev, &irdma_iw_dev_ops); ib_set_device_ops(&iwdev->ibdev, &irdma_iw_dev_ops);
return 0;
} }
/** /**
...@@ -4544,15 +4542,12 @@ static int irdma_init_iw_device(struct irdma_device *iwdev) ...@@ -4544,15 +4542,12 @@ static int irdma_init_iw_device(struct irdma_device *iwdev)
static int irdma_init_rdma_device(struct irdma_device *iwdev) static int irdma_init_rdma_device(struct irdma_device *iwdev)
{ {
struct pci_dev *pcidev = iwdev->rf->pcidev; struct pci_dev *pcidev = iwdev->rf->pcidev;
int ret;
if (iwdev->roce_mode) { if (iwdev->roce_mode)
irdma_init_roce_device(iwdev); irdma_init_roce_device(iwdev);
} else { else
ret = irdma_init_iw_device(iwdev); irdma_init_iw_device(iwdev);
if (ret)
return ret;
}
iwdev->ibdev.phys_port_cnt = 1; iwdev->ibdev.phys_port_cnt = 1;
iwdev->ibdev.num_comp_vectors = iwdev->rf->ceqs_count; iwdev->ibdev.num_comp_vectors = iwdev->rf->ceqs_count;
iwdev->ibdev.dev.parent = &pcidev->dev; iwdev->ibdev.dev.parent = &pcidev->dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment