Commit abca1f33 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Darrick J. Wong

xfs: remove the syncing argument from xlog_verify_iclog

The only caller unconditionally passes true here.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 9b0489c1
...@@ -103,8 +103,7 @@ STATIC void ...@@ -103,8 +103,7 @@ STATIC void
xlog_verify_iclog( xlog_verify_iclog(
struct xlog *log, struct xlog *log,
struct xlog_in_core *iclog, struct xlog_in_core *iclog,
int count, int count);
bool syncing);
STATIC void STATIC void
xlog_verify_tail_lsn( xlog_verify_tail_lsn(
struct xlog *log, struct xlog *log,
...@@ -113,7 +112,7 @@ xlog_verify_tail_lsn( ...@@ -113,7 +112,7 @@ xlog_verify_tail_lsn(
#else #else
#define xlog_verify_dest_ptr(a,b) #define xlog_verify_dest_ptr(a,b)
#define xlog_verify_grant_tail(a) #define xlog_verify_grant_tail(a)
#define xlog_verify_iclog(a,b,c,d) #define xlog_verify_iclog(a,b,c)
#define xlog_verify_tail_lsn(a,b,c) #define xlog_verify_tail_lsn(a,b,c)
#endif #endif
...@@ -1921,7 +1920,7 @@ xlog_sync( ...@@ -1921,7 +1920,7 @@ xlog_sync(
iclog->ic_bp->b_io_length = BTOBB(split ? split : count); iclog->ic_bp->b_io_length = BTOBB(split ? split : count);
iclog->ic_bwritecnt = split ? 2 : 1; iclog->ic_bwritecnt = split ? 2 : 1;
xlog_verify_iclog(log, iclog, count, true); xlog_verify_iclog(log, iclog, count);
xlog_write_iclog(log, iclog, iclog->ic_bp, bno, need_flush); xlog_write_iclog(log, iclog, iclog->ic_bp, bno, need_flush);
if (split) { if (split) {
...@@ -3768,8 +3767,7 @@ STATIC void ...@@ -3768,8 +3767,7 @@ STATIC void
xlog_verify_iclog( xlog_verify_iclog(
struct xlog *log, struct xlog *log,
struct xlog_in_core *iclog, struct xlog_in_core *iclog,
int count, int count)
bool syncing)
{ {
xlog_op_header_t *ophead; xlog_op_header_t *ophead;
xlog_in_core_t *icptr; xlog_in_core_t *icptr;
...@@ -3813,7 +3811,7 @@ xlog_verify_iclog( ...@@ -3813,7 +3811,7 @@ xlog_verify_iclog(
/* clientid is only 1 byte */ /* clientid is only 1 byte */
p = &ophead->oh_clientid; p = &ophead->oh_clientid;
field_offset = p - base_ptr; field_offset = p - base_ptr;
if (!syncing || (field_offset & 0x1ff)) { if (field_offset & 0x1ff) {
clientid = ophead->oh_clientid; clientid = ophead->oh_clientid;
} else { } else {
idx = BTOBBT((char *)&ophead->oh_clientid - iclog->ic_datap); idx = BTOBBT((char *)&ophead->oh_clientid - iclog->ic_datap);
...@@ -3836,7 +3834,7 @@ xlog_verify_iclog( ...@@ -3836,7 +3834,7 @@ xlog_verify_iclog(
/* check length */ /* check length */
p = &ophead->oh_len; p = &ophead->oh_len;
field_offset = p - base_ptr; field_offset = p - base_ptr;
if (!syncing || (field_offset & 0x1ff)) { if (field_offset & 0x1ff) {
op_len = be32_to_cpu(ophead->oh_len); op_len = be32_to_cpu(ophead->oh_len);
} else { } else {
idx = BTOBBT((uintptr_t)&ophead->oh_len - idx = BTOBBT((uintptr_t)&ophead->oh_len -
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment