Commit abda3469 authored by Tobias Jordan's avatar Tobias Jordan Committed by Greg Kroah-Hartman

spi: sun6i: disable/unprepare clocks on remove


[ Upstream commit 2d9bbd02 ]

sun6i_spi_probe() uses sun6i_spi_runtime_resume() to prepare/enable
clocks, so sun6i_spi_remove() should use sun6i_spi_runtime_suspend() to
disable/unprepare them if we're not suspended.
Replacing pm_runtime_disable() by pm_runtime_force_suspend() will ensure
that sun6i_spi_runtime_suspend() is called if needed.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 3558fe90 (spi: sunxi: Add Allwinner A31 SPI controller driver)
Signed-off-by: default avatarTobias Jordan <Tobias.Jordan@elektrobit.com>
Acked-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6638091f
...@@ -457,7 +457,7 @@ static int sun6i_spi_probe(struct platform_device *pdev) ...@@ -457,7 +457,7 @@ static int sun6i_spi_probe(struct platform_device *pdev)
static int sun6i_spi_remove(struct platform_device *pdev) static int sun6i_spi_remove(struct platform_device *pdev)
{ {
pm_runtime_disable(&pdev->dev); pm_runtime_force_suspend(&pdev->dev);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment