Commit abf287ee authored by Keita Suzuki's avatar Keita Suzuki Committed by Mauro Carvalho Chehab

media: siano: fix memory leak of debugfs members in smsdvb_hotplug

When dvb_create_media_graph fails, the debugfs kept inside client should
be released. However, the current implementation does not release them.

Fix this by adding a new goto label to call smsdvb_debugfs_release.

Fixes: 0d3ab841 ("[media] dvb core: must check dvb_create_media_graph()")
Signed-off-by: default avatarKeita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 4fe21dec
......@@ -1169,12 +1169,15 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev,
rc = dvb_create_media_graph(&client->adapter, true);
if (rc < 0) {
pr_err("dvb_create_media_graph failed %d\n", rc);
goto client_error;
goto media_graph_error;
}
pr_info("DVB interface registered.\n");
return 0;
media_graph_error:
smsdvb_debugfs_release(client);
client_error:
dvb_unregister_frontend(&client->frontend);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment