Commit ac897953 authored by Wen Yang's avatar Wen Yang Committed by Kleber Sacilotto de Souza

ARM: exynos: Fix a leaked reference by adding missing of_node_put

BugLink: https://bugs.launchpad.net/bugs/1832661

commit 629266bf upstream.

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with warnings like:
    arch/arm/mach-exynos/firmware.c:201:2-8: ERROR: missing of_node_put;
        acquired a node pointer with refcount incremented on line 193,
        but without a corresponding object release within this function.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 03b7b074
...@@ -207,6 +207,7 @@ void __init exynos_firmware_init(void) ...@@ -207,6 +207,7 @@ void __init exynos_firmware_init(void)
return; return;
addr = of_get_address(nd, 0, NULL, NULL); addr = of_get_address(nd, 0, NULL, NULL);
of_node_put(nd);
if (!addr) { if (!addr) {
pr_err("%s: No address specified.\n", __func__); pr_err("%s: No address specified.\n", __func__);
return; return;
......
...@@ -725,8 +725,10 @@ void __init exynos_pm_init(void) ...@@ -725,8 +725,10 @@ void __init exynos_pm_init(void)
if (WARN_ON(!of_find_property(np, "interrupt-controller", NULL))) { if (WARN_ON(!of_find_property(np, "interrupt-controller", NULL))) {
pr_warn("Outdated DT detected, suspend/resume will NOT work\n"); pr_warn("Outdated DT detected, suspend/resume will NOT work\n");
of_node_put(np);
return; return;
} }
of_node_put(np);
pm_data = (const struct exynos_pm_data *) match->data; pm_data = (const struct exynos_pm_data *) match->data;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment