Commit ac8cf0b9 authored by Boris Brezillon's avatar Boris Brezillon Committed by Miquel Raynal

mtd: rawnand: micron: Update ecc_stats.corrected

Even if we can't update ecc_stats.corrected with an accurate value we
should at least increase the number of bitflips so that MTD users can
know that there was some bitflips.

Just add chip->ecc.strength to mtd->ecc_stats.corrected which should
account for the worst case situation.
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent efc6362c
...@@ -137,18 +137,19 @@ micron_nand_read_page_on_die_ecc(struct mtd_info *mtd, struct nand_chip *chip, ...@@ -137,18 +137,19 @@ micron_nand_read_page_on_die_ecc(struct mtd_info *mtd, struct nand_chip *chip,
if (ret) if (ret)
goto out; goto out;
if (status & NAND_STATUS_FAIL) if (status & NAND_STATUS_FAIL) {
mtd->ecc_stats.failed++; mtd->ecc_stats.failed++;
} else if (status & NAND_STATUS_WRITE_RECOMMENDED) {
/* /*
* The internal ECC doesn't tell us the number of bitflips * The internal ECC doesn't tell us the number of bitflips
* that have been corrected, but tells us if it recommends to * that have been corrected, but tells us if it recommends to
* rewrite the block. If it's the case, then we pretend we had * rewrite the block. If it's the case, then we pretend we had
* a number of bitflips equal to the ECC strength, which will * a number of bitflips equal to the ECC strength, which will
* hint the NAND core to rewrite the block. * hint the NAND core to rewrite the block.
*/ */
else if (status & NAND_STATUS_WRITE_RECOMMENDED) mtd->ecc_stats.corrected += chip->ecc.strength;
max_bitflips = chip->ecc.strength; max_bitflips = chip->ecc.strength;
}
ret = nand_read_data_op(chip, buf, mtd->writesize, false); ret = nand_read_data_op(chip, buf, mtd->writesize, false);
if (!ret && oob_required) if (!ret && oob_required)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment