Commit acf50ec7 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

eeprom: fix memory leak on buf when failed allocation of csraddr_str

The error return path When csraddr_str fails to free buf, causing a
memory leak. Fix this by returning via the free_buf label that
performs the necessary cleanup.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3c84dc7e
...@@ -965,8 +965,10 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf, ...@@ -965,8 +965,10 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf,
csraddr_len = colon_ch - buf; csraddr_len = colon_ch - buf;
csraddr_str = csraddr_str =
kmalloc(sizeof(char)*(csraddr_len + 1), GFP_KERNEL); kmalloc(sizeof(char)*(csraddr_len + 1), GFP_KERNEL);
if (csraddr_str == NULL) if (csraddr_str == NULL) {
return -ENOMEM; ret = -ENOMEM;
goto free_buf;
}
/* Copy the register address to the substring buffer */ /* Copy the register address to the substring buffer */
strncpy(csraddr_str, buf, csraddr_len); strncpy(csraddr_str, buf, csraddr_len);
csraddr_str[csraddr_len] = '\0'; csraddr_str[csraddr_len] = '\0';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment