Commit ad00a325 authored by Marc Zyngier's avatar Marc Zyngier

ARM: sa1111: Fix irq_retrigger callback return value

The irq_retrigger callback is supposed to return 0 when retrigger
has failed, and a non-zero value otherwise. Tell the core code
that the driver has succedded in using the HW to retrigger the
interrupt (if ever).
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200310184921.23552-4-maz@kernel.org
parent 4ddfc459
...@@ -302,10 +302,13 @@ static int sa1111_retrigger_irq(struct irq_data *d) ...@@ -302,10 +302,13 @@ static int sa1111_retrigger_irq(struct irq_data *d)
break; break;
} }
if (i == 8) if (i == 8) {
pr_err("Danger Will Robinson: failed to re-trigger IRQ%d\n", pr_err("Danger Will Robinson: failed to re-trigger IRQ%d\n",
d->irq); d->irq);
return i == 8 ? -1 : 0; return 0;
}
return 1;
} }
static int sa1111_type_irq(struct irq_data *d, unsigned int flags) static int sa1111_type_irq(struct irq_data *d, unsigned int flags)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment