Commit ad261839 authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab

[media] dvb_usb_v2: simplify remote init/exit logic

Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 6e3a5daa
...@@ -328,7 +328,6 @@ struct dvb_usb_device { ...@@ -328,7 +328,6 @@ struct dvb_usb_device {
#define DVB_USB_STATE_INIT 0x000 #define DVB_USB_STATE_INIT 0x000
#define DVB_USB_STATE_I2C 0x001 #define DVB_USB_STATE_I2C 0x001
#define DVB_USB_STATE_DVB 0x002 #define DVB_USB_STATE_DVB 0x002
#define DVB_USB_STATE_REMOTE 0x004
int state; int state;
int powered; int powered;
......
...@@ -137,6 +137,8 @@ static int dvb_usbv2_remote_init(struct dvb_usb_device *d) ...@@ -137,6 +137,8 @@ static int dvb_usbv2_remote_init(struct dvb_usb_device *d)
int ret; int ret;
struct rc_dev *dev; struct rc_dev *dev;
pr_debug("%s:\n", __func__);
if (dvb_usbv2_disable_rc_polling || !d->props->get_rc_config) if (dvb_usbv2_disable_rc_polling || !d->props->get_rc_config)
return 0; return 0;
...@@ -190,8 +192,6 @@ static int dvb_usbv2_remote_init(struct dvb_usb_device *d) ...@@ -190,8 +192,6 @@ static int dvb_usbv2_remote_init(struct dvb_usb_device *d)
msecs_to_jiffies(d->rc.interval)); msecs_to_jiffies(d->rc.interval));
} }
d->state |= DVB_USB_STATE_REMOTE;
return 0; return 0;
err: err:
pr_debug("%s: failed=%d\n", __func__, ret); pr_debug("%s: failed=%d\n", __func__, ret);
...@@ -200,13 +200,14 @@ static int dvb_usbv2_remote_init(struct dvb_usb_device *d) ...@@ -200,13 +200,14 @@ static int dvb_usbv2_remote_init(struct dvb_usb_device *d)
static int dvb_usbv2_remote_exit(struct dvb_usb_device *d) static int dvb_usbv2_remote_exit(struct dvb_usb_device *d)
{ {
if (d->state & DVB_USB_STATE_REMOTE) { pr_debug("%s:\n", __func__);
if (d->rc_dev) {
cancel_delayed_work_sync(&d->rc_query_work); cancel_delayed_work_sync(&d->rc_query_work);
rc_unregister_device(d->rc_dev); rc_unregister_device(d->rc_dev);
d->rc_dev = NULL;
} }
d->state &= ~DVB_USB_STATE_REMOTE;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment