Commit b0445a18 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding

pwm: Narrow scope of struct pwm_device pointer

In the expression determining the size of the allocation for chip->pwms
it's more natural to use sizeof(*chip->pwms) than sizeof(*pwm). With
that changed, the variable pwm is only used in a for loop and its scope
can be reduced accordingly.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 1c9a2ad8
...@@ -208,7 +208,6 @@ static bool pwm_ops_check(const struct pwm_chip *chip) ...@@ -208,7 +208,6 @@ static bool pwm_ops_check(const struct pwm_chip *chip)
*/ */
int __pwmchip_add(struct pwm_chip *chip, struct module *owner) int __pwmchip_add(struct pwm_chip *chip, struct module *owner)
{ {
struct pwm_device *pwm;
unsigned int i; unsigned int i;
int ret; int ret;
...@@ -220,7 +219,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) ...@@ -220,7 +219,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner)
chip->owner = owner; chip->owner = owner;
chip->pwms = kcalloc(chip->npwm, sizeof(*pwm), GFP_KERNEL); chip->pwms = kcalloc(chip->npwm, sizeof(*chip->pwms), GFP_KERNEL);
if (!chip->pwms) if (!chip->pwms)
return -ENOMEM; return -ENOMEM;
...@@ -236,7 +235,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) ...@@ -236,7 +235,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner)
chip->id = ret; chip->id = ret;
for (i = 0; i < chip->npwm; i++) { for (i = 0; i < chip->npwm; i++) {
pwm = &chip->pwms[i]; struct pwm_device *pwm = &chip->pwms[i];
pwm->chip = chip; pwm->chip = chip;
pwm->hwpwm = i; pwm->hwpwm = i;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment