Commit b06c19d9 authored by Ira Weiny's avatar Ira Weiny Committed by David S. Miller

net/tls: Fix kmap usage

When MSG_OOB is specified to tls_device_sendpage() the mapped page is
never unmapped.

Hold off mapping the page until after the flags are checked and the page
is actually needed.

Fixes: e8f69799 ("net/tls: Add generic NIC offload infrastructure")
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 444da3f5
...@@ -561,7 +561,7 @@ int tls_device_sendpage(struct sock *sk, struct page *page, ...@@ -561,7 +561,7 @@ int tls_device_sendpage(struct sock *sk, struct page *page,
{ {
struct tls_context *tls_ctx = tls_get_ctx(sk); struct tls_context *tls_ctx = tls_get_ctx(sk);
struct iov_iter msg_iter; struct iov_iter msg_iter;
char *kaddr = kmap(page); char *kaddr;
struct kvec iov; struct kvec iov;
int rc; int rc;
...@@ -576,6 +576,7 @@ int tls_device_sendpage(struct sock *sk, struct page *page, ...@@ -576,6 +576,7 @@ int tls_device_sendpage(struct sock *sk, struct page *page,
goto out; goto out;
} }
kaddr = kmap(page);
iov.iov_base = kaddr + offset; iov.iov_base = kaddr + offset;
iov.iov_len = size; iov.iov_len = size;
iov_iter_kvec(&msg_iter, WRITE, &iov, 1, size); iov_iter_kvec(&msg_iter, WRITE, &iov, 1, size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment