Commit b1f03900 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Daniel Lezcano

clocksource/drivers/timer-ti-dm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230313075430.2730803-6-u.kleine-koenig@pengutronix.de
parent d7b76421
...@@ -1177,7 +1177,7 @@ static int omap_dm_timer_probe(struct platform_device *pdev) ...@@ -1177,7 +1177,7 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
* In addition to freeing platform resources it also deletes the timer * In addition to freeing platform resources it also deletes the timer
* entry from the local list. * entry from the local list.
*/ */
static int omap_dm_timer_remove(struct platform_device *pdev) static void omap_dm_timer_remove(struct platform_device *pdev)
{ {
struct dmtimer *timer; struct dmtimer *timer;
unsigned long flags; unsigned long flags;
...@@ -1199,8 +1199,6 @@ static int omap_dm_timer_remove(struct platform_device *pdev) ...@@ -1199,8 +1199,6 @@ static int omap_dm_timer_remove(struct platform_device *pdev)
if (ret) if (ret)
dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n"); dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n");
return 0;
} }
static const struct omap_dm_timer_ops dmtimer_ops = { static const struct omap_dm_timer_ops dmtimer_ops = {
...@@ -1275,7 +1273,7 @@ MODULE_DEVICE_TABLE(of, omap_timer_match); ...@@ -1275,7 +1273,7 @@ MODULE_DEVICE_TABLE(of, omap_timer_match);
static struct platform_driver omap_dm_timer_driver = { static struct platform_driver omap_dm_timer_driver = {
.probe = omap_dm_timer_probe, .probe = omap_dm_timer_probe,
.remove = omap_dm_timer_remove, .remove_new = omap_dm_timer_remove,
.driver = { .driver = {
.name = "omap_timer", .name = "omap_timer",
.of_match_table = omap_timer_match, .of_match_table = omap_timer_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment