Commit b25e10f8 authored by Linus Walleij's avatar Linus Walleij

gpio: siox: Pass irqchip when adding gpiochip

We need to convert all old gpio irqchips to pass the irqchip
setup along when adding the gpio_chip.

For chained irqchips this is a pretty straight-forward
conversion.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <treding@nvidia.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 87b70378
...@@ -211,6 +211,7 @@ static int gpio_siox_get_direction(struct gpio_chip *chip, unsigned int offset) ...@@ -211,6 +211,7 @@ static int gpio_siox_get_direction(struct gpio_chip *chip, unsigned int offset)
static int gpio_siox_probe(struct siox_device *sdevice) static int gpio_siox_probe(struct siox_device *sdevice)
{ {
struct gpio_siox_ddata *ddata; struct gpio_siox_ddata *ddata;
struct gpio_irq_chip *girq;
int ret; int ret;
ddata = devm_kzalloc(&sdevice->dev, sizeof(*ddata), GFP_KERNEL); ddata = devm_kzalloc(&sdevice->dev, sizeof(*ddata), GFP_KERNEL);
...@@ -239,18 +240,15 @@ static int gpio_siox_probe(struct siox_device *sdevice) ...@@ -239,18 +240,15 @@ static int gpio_siox_probe(struct siox_device *sdevice)
ddata->ichip.irq_unmask = gpio_siox_irq_unmask; ddata->ichip.irq_unmask = gpio_siox_irq_unmask;
ddata->ichip.irq_set_type = gpio_siox_irq_set_type; ddata->ichip.irq_set_type = gpio_siox_irq_set_type;
ret = gpiochip_add(&ddata->gchip); girq = &ddata->gchip.irq;
if (ret) { girq->chip = &ddata->ichip;
dev_err(&sdevice->dev, girq->default_type = IRQ_TYPE_NONE;
"Failed to register gpio chip (%d)\n", ret); girq->handler = handle_level_irq;
return ret;
}
ret = gpiochip_irqchip_add(&ddata->gchip, &ddata->ichip, ret = gpiochip_add(&ddata->gchip);
0, handle_level_irq, IRQ_TYPE_NONE);
if (ret) if (ret)
dev_err(&sdevice->dev, dev_err(&sdevice->dev,
"Failed to register irq chip (%d)\n", ret); "Failed to register gpio chip (%d)\n", ret);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment