Commit b2bc4782 authored by Goldwyn Rodrigues's avatar Goldwyn Rodrigues Committed by Linus Torvalds

RDMA: Check for NULL mode in .devnode methods

Commits 71c29bd5 ("IB/uverbs: Add devnode method to set path/mode")
and c3af0980 ("IB: Add devnode methods to cm_class and umad_class")
added devnode methods that set the mode.

However, these methods don't check for a NULL mode, and so we get a
crash when unloading modules because devtmpfs_delete_node() calls
device_get_devnode() with mode == NULL.

Add the missing checks.
Signed-off-by: default avatarGoldwyn Rodrigues <rgoldwyn@suse.de>
[ Also fix cm.c.  - Roland ]
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ba466c74
...@@ -3641,7 +3641,8 @@ static struct kobj_type cm_port_obj_type = { ...@@ -3641,7 +3641,8 @@ static struct kobj_type cm_port_obj_type = {
static char *cm_devnode(struct device *dev, mode_t *mode) static char *cm_devnode(struct device *dev, mode_t *mode)
{ {
*mode = 0666; if (mode)
*mode = 0666;
return kasprintf(GFP_KERNEL, "infiniband/%s", dev_name(dev)); return kasprintf(GFP_KERNEL, "infiniband/%s", dev_name(dev));
} }
......
...@@ -826,7 +826,8 @@ static void ib_uverbs_remove_one(struct ib_device *device) ...@@ -826,7 +826,8 @@ static void ib_uverbs_remove_one(struct ib_device *device)
static char *uverbs_devnode(struct device *dev, mode_t *mode) static char *uverbs_devnode(struct device *dev, mode_t *mode)
{ {
*mode = 0666; if (mode)
*mode = 0666;
return kasprintf(GFP_KERNEL, "infiniband/%s", dev_name(dev)); return kasprintf(GFP_KERNEL, "infiniband/%s", dev_name(dev));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment