Commit b327c727 authored by Joakim Zhang's avatar Joakim Zhang Committed by Mathieu Poirier

remoteproc: virtio: Fix wdg cannot recovery remote processor

Recovery remote processor failed when wdg irq received:
[    0.842574] remoteproc remoteproc0: crash detected in cix-dsp-rproc: type watchdog
[    0.842750] remoteproc remoteproc0: handling crash #1 in cix-dsp-rproc
[    0.842824] remoteproc remoteproc0: recovering cix-dsp-rproc
[    0.843342] remoteproc remoteproc0: stopped remote processor cix-dsp-rproc
[    0.847901] rproc-virtio rproc-virtio.0.auto: Failed to associate buffer
[    0.847979] remoteproc remoteproc0: failed to probe subdevices for cix-dsp-rproc: -16

The reason is that dma coherent mem would not be released when
recovering the remote processor, due to rproc_virtio_remove()
would not be called, where the mem released. It will fail when
it try to allocate and associate buffer again.

Releasing reserved memory from rproc_virtio_dev_release(), instead of
rproc_virtio_remove().

Fixes: 1d7b61c0 ("remoteproc: virtio: Create platform device for the remoteproc_virtio")
Signed-off-by: default avatarJoakim Zhang <joakim.zhang@cixtech.com>
Acked-by: default avatarArnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20231217053659.3245745-1-joakim.zhang@cixtech.comSigned-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 6613476e
...@@ -351,6 +351,9 @@ static void rproc_virtio_dev_release(struct device *dev) ...@@ -351,6 +351,9 @@ static void rproc_virtio_dev_release(struct device *dev)
kfree(vdev); kfree(vdev);
of_reserved_mem_device_release(&rvdev->pdev->dev);
dma_release_coherent_memory(&rvdev->pdev->dev);
put_device(&rvdev->pdev->dev); put_device(&rvdev->pdev->dev);
} }
...@@ -584,9 +587,6 @@ static void rproc_virtio_remove(struct platform_device *pdev) ...@@ -584,9 +587,6 @@ static void rproc_virtio_remove(struct platform_device *pdev)
rproc_remove_subdev(rproc, &rvdev->subdev); rproc_remove_subdev(rproc, &rvdev->subdev);
rproc_remove_rvdev(rvdev); rproc_remove_rvdev(rvdev);
of_reserved_mem_device_release(&pdev->dev);
dma_release_coherent_memory(&pdev->dev);
put_device(&rproc->dev); put_device(&rproc->dev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment