Commit b3c0fd61 authored by Bart Van Assche's avatar Bart Van Assche Committed by David S. Miller

net/core: Document all dev_ioctl() arguments

This patch avoids that the following warnings are reported when building
with W=1:

net/core/dev_ioctl.c:378: warning: Function parameter or member 'ifr' not described in 'dev_ioctl'
net/core/dev_ioctl.c:378: warning: Function parameter or member 'need_copyout' not described in 'dev_ioctl'
net/core/dev_ioctl.c:378: warning: Excess function parameter 'arg' description in 'dev_ioctl'

Cc: Al Viro <viro@zeniv.linux.org.uk>
Fixes: 44c02a2c ("dev_ioctl(): move copyin/copyout to callers") # v4.16.
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 37f3c421
...@@ -366,7 +366,8 @@ EXPORT_SYMBOL(dev_load); ...@@ -366,7 +366,8 @@ EXPORT_SYMBOL(dev_load);
* dev_ioctl - network device ioctl * dev_ioctl - network device ioctl
* @net: the applicable net namespace * @net: the applicable net namespace
* @cmd: command to issue * @cmd: command to issue
* @arg: pointer to a struct ifreq in user space * @ifr: pointer to a struct ifreq in user space
* @need_copyout: whether or not copy_to_user() should be called
* *
* Issue ioctl functions to devices. This is normally called by the * Issue ioctl functions to devices. This is normally called by the
* user space syscall interfaces but can sometimes be useful for * user space syscall interfaces but can sometimes be useful for
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment