Commit b3d58eaf authored by Al Viro's avatar Al Viro

atomic_open(): be paranoid about may_open() return value

It should never return positives; however, with Linux S&M crowd
involved, no bogosity is impossible.  Results would be unpleasant...
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 0fb1ea09
...@@ -2920,6 +2920,8 @@ static int atomic_open(struct nameidata *nd, struct dentry *dentry, ...@@ -2920,6 +2920,8 @@ static int atomic_open(struct nameidata *nd, struct dentry *dentry,
acc_mode = 0; acc_mode = 0;
} }
error = may_open(&file->f_path, acc_mode, open_flag); error = may_open(&file->f_path, acc_mode, open_flag);
if (WARN_ON(error > 0))
error = -EINVAL;
out: out:
dput(dentry); dput(dentry);
return error; return error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment