Commit b471927e authored by Boqun Feng's avatar Boqun Feng Committed by Miguel Ojeda

kallsyms: avoid hardcoding buffer size

This introduces `KSYM_NAME_LEN_BUFFER` in place of the previously
hardcoded size of the input buffer.

It will also make it easier to update the size in a single place
in a later patch.
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarBoqun Feng <boqun.feng@gmail.com>
Co-developed-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent b66c874f
...@@ -27,8 +27,14 @@ ...@@ -27,8 +27,14 @@
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0]))
#define _stringify_1(x) #x
#define _stringify(x) _stringify_1(x)
#define KSYM_NAME_LEN 128 #define KSYM_NAME_LEN 128
/* A substantially bigger size than the current maximum. */
#define KSYM_NAME_LEN_BUFFER 499
struct sym_entry { struct sym_entry {
unsigned long long addr; unsigned long long addr;
unsigned int len; unsigned int len;
...@@ -198,13 +204,13 @@ static void check_symbol_range(const char *sym, unsigned long long addr, ...@@ -198,13 +204,13 @@ static void check_symbol_range(const char *sym, unsigned long long addr,
static struct sym_entry *read_symbol(FILE *in) static struct sym_entry *read_symbol(FILE *in)
{ {
char name[500], type; char name[KSYM_NAME_LEN_BUFFER+1], type;
unsigned long long addr; unsigned long long addr;
unsigned int len; unsigned int len;
struct sym_entry *sym; struct sym_entry *sym;
int rc; int rc;
rc = fscanf(in, "%llx %c %499s\n", &addr, &type, name); rc = fscanf(in, "%llx %c %" _stringify(KSYM_NAME_LEN_BUFFER) "s\n", &addr, &type, name);
if (rc != 3) { if (rc != 3) {
if (rc != EOF && fgets(name, ARRAY_SIZE(name), in) == NULL) if (rc != EOF && fgets(name, ARRAY_SIZE(name), in) == NULL)
fprintf(stderr, "Read error or end of file.\n"); fprintf(stderr, "Read error or end of file.\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment