Commit b55226f8 authored by Xiu Jianfeng's avatar Xiu Jianfeng Committed by Stephen Boyd

clk: visconti: Fix memory leak in visconti_register_pll()

@pll->rate_table has allocated memory by kmemdup(), if clk_hw_register()
fails, it should be freed, otherwise it will cause memory leak issue,
this patch fixes it.

Fixes: b4cbe606 ("clk: visconti: Add support common clock driver and reset driver")
Signed-off-by: default avatarXiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221122152353.204132-1-xiujianfeng@huawei.comAcked-by: default avatarNobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 12897adc
...@@ -277,6 +277,7 @@ static struct clk_hw *visconti_register_pll(struct visconti_pll_provider *ctx, ...@@ -277,6 +277,7 @@ static struct clk_hw *visconti_register_pll(struct visconti_pll_provider *ctx,
ret = clk_hw_register(NULL, &pll->hw); ret = clk_hw_register(NULL, &pll->hw);
if (ret) { if (ret) {
pr_err("failed to register pll clock %s : %d\n", name, ret); pr_err("failed to register pll clock %s : %d\n", name, ret);
kfree(pll->rate_table);
kfree(pll); kfree(pll);
pll_hw_clk = ERR_PTR(ret); pll_hw_clk = ERR_PTR(ret);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment