Commit b666dbf8 authored by Philipp Reisner's avatar Philipp Reisner

drbd: Remove redundant and wrong test for NULL simplification in conn_connect()

Since the drbd_socket_okay() function itself tests if the the
socket is NULL, the explicit test "if (sock.socket && &msock.socket)"
was redundent.
Apart from that the address opperator ('&') before msock.socket rendered
the test pointless.
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
parent 3174f8c5
...@@ -985,13 +985,9 @@ static int conn_connect(struct drbd_tconn *tconn) ...@@ -985,13 +985,9 @@ static int conn_connect(struct drbd_tconn *tconn)
goto out_release_sockets; goto out_release_sockets;
} }
if (sock.socket && &msock.socket) { ok = drbd_socket_okay(&sock.socket);
ok = drbd_socket_okay(&sock.socket); ok = drbd_socket_okay(&msock.socket) && ok;
ok = drbd_socket_okay(&msock.socket) && ok; } while (!ok);
if (ok)
break;
}
} while (1);
if (ad.s_listen) if (ad.s_listen)
sock_release(ad.s_listen); sock_release(ad.s_listen);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment