Commit b738a50a authored by Thomas Gleixner's avatar Thomas Gleixner

genirq: Warn when handler enables interrupts

We run all handlers with interrupts disabled and expect them not to
enable them. Warn when we catch one who does.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 1082687e
...@@ -68,6 +68,9 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action) ...@@ -68,6 +68,9 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
ret = action->handler(irq, action->dev_id); ret = action->handler(irq, action->dev_id);
trace_irq_handler_exit(irq, action, ret); trace_irq_handler_exit(irq, action, ret);
if (WARN_ON_ONCE(!irqs_disabled()))
local_irq_disable();
switch (ret) { switch (ret) {
case IRQ_WAKE_THREAD: case IRQ_WAKE_THREAD:
/* /*
...@@ -114,7 +117,6 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action) ...@@ -114,7 +117,6 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
if (status & IRQF_SAMPLE_RANDOM) if (status & IRQF_SAMPLE_RANDOM)
add_interrupt_randomness(irq); add_interrupt_randomness(irq);
local_irq_disable();
return retval; return retval;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment