Commit b7b7e1ab authored by Takashi Iwai's avatar Takashi Iwai

ALSA: usb-audio: Correct surround channels in UAC1 channel map

USB-audio driver puts SNDRV_CHMAP_SL and _SR as left and right
surround channels for UAC1 channel map, respectively.  But they should
have been SNDRV_CHMAP_RL and _RR; the current value *_SL and _SR are
rather "side" channels, not "surround".  I guess I took those
mistakenly when I read the spec mentioning "surround left".

This patch corrects those entries to be the right channels.
Suggested-by: default avatarSylvain BERTRAND <sylvain.bertrand@legeek.net>
Closes: https://lore.kernel.orgZ/qIyJD8lhd8hFhlC@freedom
Fixes: 04324ccc ("ALSA: usb-audio: add channel map support")
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20240731142018.24750-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 98ea612d
...@@ -244,8 +244,8 @@ static struct snd_pcm_chmap_elem *convert_chmap(int channels, unsigned int bits, ...@@ -244,8 +244,8 @@ static struct snd_pcm_chmap_elem *convert_chmap(int channels, unsigned int bits,
SNDRV_CHMAP_FR, /* right front */ SNDRV_CHMAP_FR, /* right front */
SNDRV_CHMAP_FC, /* center front */ SNDRV_CHMAP_FC, /* center front */
SNDRV_CHMAP_LFE, /* LFE */ SNDRV_CHMAP_LFE, /* LFE */
SNDRV_CHMAP_SL, /* left surround */ SNDRV_CHMAP_RL, /* left surround */
SNDRV_CHMAP_SR, /* right surround */ SNDRV_CHMAP_RR, /* right surround */
SNDRV_CHMAP_FLC, /* left of center */ SNDRV_CHMAP_FLC, /* left of center */
SNDRV_CHMAP_FRC, /* right of center */ SNDRV_CHMAP_FRC, /* right of center */
SNDRV_CHMAP_RC, /* surround */ SNDRV_CHMAP_RC, /* surround */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment