Commit b7db5810 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

staging: greybus: use after free in gb_audio_manager_remove_all()

When we call kobject_put() and it's the last reference to the kobject
then it calls gb_audio_module_release() and frees module.  We dereference
"module" on the next line which is a use after free.

Fixes: c77f85bb ("greybus: audio: Fix incorrect counting of 'ida'")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarVaibhav Agarwal <vaibhav.sr@gmail.com>
Link: https://lore.kernel.org/r/20200205123217.jreendkyxulqsool@kili.mountainSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c3709b32
...@@ -92,8 +92,8 @@ void gb_audio_manager_remove_all(void) ...@@ -92,8 +92,8 @@ void gb_audio_manager_remove_all(void)
list_for_each_entry_safe(module, next, &modules_list, list) { list_for_each_entry_safe(module, next, &modules_list, list) {
list_del(&module->list); list_del(&module->list);
kobject_put(&module->kobj);
ida_simple_remove(&module_id, module->id); ida_simple_remove(&module_id, module->id);
kobject_put(&module->kobj);
} }
is_empty = list_empty(&modules_list); is_empty = list_empty(&modules_list);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment