Commit b81d67a5 authored by Julia Lawall's avatar Julia Lawall Committed by Linus Torvalds

drivers/message/i2o/i2o_config.c: use memdup_user

Use memdup_user when user data is immediately copied into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@

-  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+  to = memdup_user(from,size);
   if (
-      to==NULL
+      IS_ERR(to)
                 || ...) {
   <+... when != goto l1;
-  -ENOMEM
+  PTR_ERR(to)
   ...+>
   }
-  if (copy_from_user(to, from, size) != 0) {
-    <+... when != goto l2;
-    -EFAULT
-    ...+>
-  }
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9b71ca20
...@@ -186,14 +186,9 @@ static int i2o_cfg_parms(unsigned long arg, unsigned int type) ...@@ -186,14 +186,9 @@ static int i2o_cfg_parms(unsigned long arg, unsigned int type)
if (!dev) if (!dev)
return -ENXIO; return -ENXIO;
ops = kmalloc(kcmd.oplen, GFP_KERNEL); ops = memdup_user(kcmd.opbuf, kcmd.oplen);
if (!ops) if (IS_ERR(ops))
return -ENOMEM; return PTR_ERR(ops);
if (copy_from_user(ops, kcmd.opbuf, kcmd.oplen)) {
kfree(ops);
return -EFAULT;
}
/* /*
* It's possible to have a _very_ large table * It's possible to have a _very_ large table
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment