Commit b864ddb5 authored by Jaegeuk Kim's avatar Jaegeuk Kim

f2fs: fix false alarm on invalid block address

f2fs_ra_meta_pages can try to read ahead on invalid block address which is
not the corruption case.

Cc: <stable@kernel.org> # v6.9+
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218770
Fixes: 31f85ccc ("f2fs: unify the error handling of f2fs_is_valid_blkaddr")
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 2174035a
...@@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, ...@@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi,
break; break;
case META_SIT: case META_SIT:
if (unlikely(blkaddr >= SIT_BLK_CNT(sbi))) if (unlikely(blkaddr >= SIT_BLK_CNT(sbi)))
goto err; goto check_only;
break; break;
case META_SSA: case META_SSA:
if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) || if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) ||
blkaddr < SM_I(sbi)->ssa_blkaddr)) blkaddr < SM_I(sbi)->ssa_blkaddr))
goto err; goto check_only;
break; break;
case META_CP: case META_CP:
if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr || if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr ||
blkaddr < __start_cp_addr(sbi))) blkaddr < __start_cp_addr(sbi)))
goto err; goto check_only;
break; break;
case META_POR: case META_POR:
if (unlikely(blkaddr >= MAX_BLKADDR(sbi) || if (unlikely(blkaddr >= MAX_BLKADDR(sbi) ||
blkaddr < MAIN_BLKADDR(sbi))) blkaddr < MAIN_BLKADDR(sbi)))
goto err; goto check_only;
break; break;
case DATA_GENERIC: case DATA_GENERIC:
case DATA_GENERIC_ENHANCE: case DATA_GENERIC_ENHANCE:
...@@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, ...@@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi,
return true; return true;
err: err:
f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR); f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR);
check_only:
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment